fix!: ResponseMessageをResponseStatusに名称変更 #5399
Open
+119
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qs-F
requested review from
AtsushiM and
s-sasaki-0529
and removed request for
a team
commit: |
AtsushiM
reviewed
Feb 20, 2025
|
あ〜 exportsフィールドを追加するとlibとかからimportしてたやつが使えないのか… そりゃそうだ |
|
libディレクトリからもimportできるように調整完了 |
uknmr
reviewed
Mar 5, 2025
| @@ -7,7 +7,6 @@ import { Stack } from '../../../Layout' | |||
| import { Text } from '../../../Text' | |||
| import { MultiComboBox } from '../MultiComboBox' | |||
|
|
|||
| // eslint-disable-next-line storybook/prefer-pascal-case | |||
There was a problem hiding this comment.
そもそもstorybookってlintの対象外になってませんか？
対象になっていた時代の名残なような気がします
There was a problem hiding this comment.
おっ、そうなんですね? 対象外であれば消しで問題ないです!
There was a problem hiding this comment.
ですね！ここは消して良さそうだったので消しました
Comment on lines
-1
to
-3
| /* eslint-disable smarthr/a11y-input-has-name-attribute */ | ||
| /* eslint-disable smarthr/a11y-prohibit-input-placeholder */ | ||
| /* eslint-disable smarthr/a11y-input-in-form-control */ |
There was a problem hiding this comment.
消されててエラーなかった気がしたのでそのままにしちゃったんですが、一応確認してきます！
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable smarthr/a11y-input-in-form-control */ | |||
There was a problem hiding this comment.
消されててエラーなかった気がしたのでそのままにしちゃったんですが、一応確認してきます！
| "./src/*" | ||
| ] | ||
| }, | ||
| "target": "ES2017" |
There was a problem hiding this comment.
うお、これは意図的じゃないです！！フォーマットかかっただけかと思ってたら見落としてました 😇
AtsushiM
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://kufuinc.slack.com/archives/CGC58MW01/p1739929345355399
概要
ResponseMessageTypeをルートからexportするようにした
変更内容
確認方法